test(matter): Add device_interactor for side-channel by cleithner-comcast · Pull Request #140 · rdkcentral/BartonCore

cleithner-comcast · 2026-02-12T16:00:20Z

To enable tests to manipulate matter devices through a side channel, this commit adds device_interactor which is backed by chip-tool. Concrete device fixtures are commissioned by chip-tool and then their commissioning window is re-opened so that they can be commissioned by barton. This commit also adds "clusters" which are just abstractions for cluster interactions, utilizing the device_interactor. Tests can trivially access a device fixture's cluster and perform an interaction through it.

Refs: BARTON-343

To enable tests to manipulate matter devices through a side channel, this commit adds device_interactor which is backed by chip-tool. Concrete device fixtures are commissioned by chip-tool and then their commissioning window is re-opened so that they can be commissioned by barton. This commit also adds "clusters" which are just abstractions for cluster interactions, utilizing the device_interactor. Tests can trivially access a device fixture's cluster and perform an interaction through it. Refs: BARTON-343

rdkcmf-jenkins · 2026-02-12T16:01:10Z

b'## Copyright scan failure
Commit: c353a4a
Report detail: https://gist.github.com/rdkcmf-jenkins/191da37a871a9edbecd6be87f6d81a03'

Copilot

Pull request overview

This PR adds side-channel device interaction capabilities for Matter device testing by introducing device_interactor backed by chip-tool. The changes enable tests to manipulate Matter devices outside of the primary control path, supporting multi-admin commissioning scenarios.

Changes:

Added ChipToolDeviceInteractor class for executing chip-tool commands against Matter devices
Implemented cluster abstraction interfaces (OnOff, LevelControl, ColorControl) for simplified device interactions
Refactored MatterDevice to support cluster registration and multi-admin commissioning workflows
Added new test demonstrating light on/off control via side channel

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
testing/test/light_test.py	Added test validating light on/off state changes through side-channel cluster interaction
testing/mocks/devices/matter/matter_light.py	Registered supported clusters and updated fixture to enable multi-admin commissioning
testing/mocks/devices/matter/matter_device.py	Added cluster management, removed pipe-based communication, added KVS isolation
testing/mocks/devices/matter/device_interactor.py	New module providing chip-tool wrapper for device commissioning and cluster interactions
testing/mocks/devices/matter/clusters/onoff_cluster.py	New OnOff cluster implementation with command and attribute methods
testing/mocks/devices/matter/clusters/matter_cluster.py	New abstract base class for Matter cluster interfaces
testing/mocks/devices/matter/clusters/levelcontrol_cluster.py	New LevelControl cluster implementation for brightness/level control
testing/mocks/devices/matter/clusters/colorcontrol_cluster.py	New ColorControl cluster implementation for color manipulation
testing/conftest.py	Added device_interactor fixture registration
pyproject.toml	Enabled pytest-forked plugin for test isolation
docker/version	Bumped Docker image version
docker/Dockerfile	Pinned pygobject-stubs version and added pytest-forked dependency
.vscode/settings.json	Configured pytest to run tests from testing directory

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

testing/test/light_test.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

rdkcmf-jenkins · 2026-02-12T16:15:54Z

b'## Copyright scan failure
Commit: 3ed96bb
Report detail: https://gist.github.com/rdkcmf-jenkins/476fae625dfbfa06b928f923dbd582c6'

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

rdkcmf-jenkins · 2026-02-12T16:16:40Z

b'## Copyright scan failure
Commit: 93005c1
Report detail: https://gist.github.com/rdkcmf-jenkins/06411716041b400fd49e59f37312e777'

rdkcmf-jenkins · 2026-02-12T16:17:26Z

b'## Copyright scan failure
Commit: 93005c1
Report detail: https://gist.github.com/rdkcmf-jenkins/e827af6f8580549d641f0302f0187772'

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

testing/test/light_test.py

testing/mocks/devices/matter/clusters/matter_cluster.py

testing/mocks/devices/matter/device_interactor.py

testing/mocks/devices/matter/clusters/onoff_cluster.py

rdkcmf-jenkins · 2026-02-12T23:46:24Z

b'## WARNING: A Copyright scan failure has been waived

A prior failure has been upvoted

Upvote reason: ok
Commit: 93005c1
'

rdkcmf-jenkins · 2026-02-13T17:40:57Z

b'## Copyright scan failure
Commit: c4f0189
Report detail: https://gist.github.com/rdkcmf-jenkins/0f3452dc53db978ca4720bd4a9d5cd1c'

rdkcmf-jenkins · 2026-02-13T19:19:13Z

b'## WARNING: A Copyright scan failure has been waived

A prior failure has been upvoted

Upvote reason: ok
Commit: c4f0189
'

rdkcmf-jenkins · 2026-02-13T21:41:48Z

b'## Copyright scan failure
Commit: dea1a82
Report detail: https://gist.github.com/rdkcmf-jenkins/e0c9800f704e12df6d05382901db09a6'

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

testing/mocks/devices/matter/device_interactor.py

cleithner-comcast · 2026-02-13T21:49:49Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2026-02-13T21:49:57Z

@cleithner-comcast I've opened a new pull request, #145, to work on those changes. Once the pull request is ready, I'll request review from you.

Applied fixes for three unresolved code review comments from PR #140: - **Removed unused imports**: Cleaned up `threading` and `Callable` imports from `testing/test/light_test.py` - **Moved module-level import**: Relocated `re` import to top of `device_interactor.py` per Python conventions - **Added commissioning window failure handling**: Device registration now raises `RuntimeError` if commissioning window fails to open when `open_commissioning_window=True`, preventing silent failures during multi-admin setup ```python if open_commissioning_window: result, new_code = self._open_commissioning_window(...) if not result.success: raise RuntimeError( f"Failed to open commissioning window on node {node_id}: {result.stderr}" ) ```  --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: cleithner-comcast <87389808+cleithner-comcast@users.noreply.github.com>

github-actions · 2026-02-13T21:56:14Z

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

_{You can retrigger this bot by commenting recheck in this Pull Request.}_{Posted by the CLA Assistant Lite bot.}

rdkcmf-jenkins · 2026-02-13T21:56:24Z

b'## Copyright scan failure
Commit: 8251754
Report detail: https://gist.github.com/rdkcmf-jenkins/caa088d9cca4c0c0747814b5f2ac7bb4'

rdkcmf-jenkins · 2026-02-16T10:16:51Z

b'## WARNING: A Copyright scan failure has been waived

A prior failure has been upvoted

Upvote reason: ok
Commit: 8251754
'

tleacmcsa

I hereby formally approve this Pull Request.

cleithner-comcast requested review from kfundecmcsa, mkkoch and tleacmcsa as code owners February 12, 2026 16:00

Copilot AI review requested due to automatic review settings February 12, 2026 16:00

Copilot AI reviewed Feb 12, 2026

View reviewed changes

testing/test/light_test.py Outdated Show resolved Hide resolved

testing/test/light_test.py Outdated Show resolved Hide resolved

cleithner-comcast and others added 2 commits February 12, 2026 16:14

Remove copyright from settings.json#

4d73811

Update testing/test/light_test.py

3ed96bb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 12, 2026 16:15

Update testing/test/light_test.py

93005c1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Feb 12, 2026

View reviewed changes

testing/test/light_test.py Outdated Show resolved Hide resolved

tleacmcsa reviewed Feb 12, 2026

View reviewed changes

Maintenance

c4f0189

oops, minimum timeout for commissioning window

dea1a82

Copilot AI review requested due to automatic review settings February 13, 2026 21:41

Copilot started reviewing on behalf of cleithner-comcast February 13, 2026 21:41 View session

Copilot AI reviewed Feb 13, 2026

View reviewed changes

testing/mocks/devices/matter/device_interactor.py Show resolved Hide resolved

testing/mocks/devices/matter/device_interactor.py Outdated Show resolved Hide resolved

Copilot AI mentioned this pull request Feb 13, 2026

Address unresolved code review comments in device_interactor PR #145

Merged

tleacmcsa approved these changes Feb 16, 2026

View reviewed changes

cleithner-comcast merged commit 9ecab83 into main Feb 16, 2026
10 of 11 checks passed

cleithner-comcast deleted the chipToolTesting branch February 16, 2026 14:55

github-actions bot locked and limited conversation to collaborators Feb 16, 2026

Conversation

cleithner-comcast commented Feb 12, 2026

Uh oh!

rdkcmf-jenkins commented Feb 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

rdkcmf-jenkins commented Feb 12, 2026

Uh oh!

rdkcmf-jenkins commented Feb 12, 2026

Uh oh!

rdkcmf-jenkins commented Feb 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rdkcmf-jenkins commented Feb 12, 2026

Uh oh!

rdkcmf-jenkins commented Feb 13, 2026

Uh oh!

rdkcmf-jenkins commented Feb 13, 2026

Uh oh!

rdkcmf-jenkins commented Feb 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

cleithner-comcast commented Feb 13, 2026

Uh oh!

Copilot AI commented Feb 13, 2026

Uh oh!

github-actions bot commented Feb 13, 2026

Uh oh!

rdkcmf-jenkins commented Feb 13, 2026

Uh oh!

rdkcmf-jenkins commented Feb 16, 2026

Uh oh!

tleacmcsa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants