Skip to content

Address unresolved code review comments in device_interactor PR#145

Merged
cleithner-comcast merged 3 commits intochipToolTestingfrom
copilot/sub-pr-140
Feb 13, 2026
Merged

Address unresolved code review comments in device_interactor PR#145
cleithner-comcast merged 3 commits intochipToolTestingfrom
copilot/sub-pr-140

Conversation

Copy link

Copilot AI commented Feb 13, 2026

Applied fixes for three unresolved code review comments from PR #140:

  • Removed unused imports: Cleaned up threading and Callable imports from testing/test/light_test.py
  • Moved module-level import: Relocated re import to top of device_interactor.py per Python conventions
  • Added commissioning window failure handling: Device registration now raises RuntimeError if commissioning window fails to open when open_commissioning_window=True, preventing silent failures during multi-admin setup
if open_commissioning_window:
    result, new_code = self._open_commissioning_window(...)
    if not result.success:
        raise RuntimeError(
            f"Failed to open commissioning window on node {node_id}: {result.stderr}"
        )

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits February 13, 2026 21:51
…handle commissioning window failure

Co-authored-by: cleithner-comcast <87389808+cleithner-comcast@users.noreply.github.com>
Co-authored-by: cleithner-comcast <87389808+cleithner-comcast@users.noreply.github.com>
Copilot AI changed the title [WIP] Add device interactor for side-channel testing Address unresolved code review comments in device_interactor PR Feb 13, 2026
@github-actions
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@cleithner-comcast cleithner-comcast marked this pull request as ready for review February 13, 2026 21:55
Copilot AI review requested due to automatic review settings February 13, 2026 21:55
@cleithner-comcast cleithner-comcast merged commit 8251754 into chipToolTesting Feb 13, 2026
3 of 8 checks passed
@cleithner-comcast cleithner-comcast deleted the copilot/sub-pr-140 branch February 13, 2026 21:55
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants