Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: loadData not keep fresh #599

Merged
merged 5 commits into from
Nov 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/OptionList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -241,13 +241,15 @@ const OptionList: React.ForwardRefRenderFunction<ReviseRefOptionListProps> = (_,
onKeyUp: () => {},
}));

const loadDataFun = useMemo(
() => (searchValue ? null : (loadData as any)),
const hasLoadDataFn = useMemo(
() => (searchValue ? false : true),
[searchValue, treeExpandedKeys || expandedKeys],
([preSearchValue], [nextSearchValue, nextExcludeSearchExpandedKeys]) =>
preSearchValue !== nextSearchValue && !!(nextSearchValue || nextExcludeSearchExpandedKeys),
);

const syncLoadData = hasLoadDataFn ? loadData : null;

// ========================== Render ==========================
if (memoTreeData.length === 0) {
return (
Expand Down Expand Up @@ -289,7 +291,7 @@ const OptionList: React.ForwardRefRenderFunction<ReviseRefOptionListProps> = (_,
showIcon={showTreeIcon}
switcherIcon={switcherIcon}
showLine={treeLine}
loadData={loadDataFun}
loadData={syncLoadData}
motion={treeMotion}
activeKey={activeKey}
// We handle keys by out instead tree self
Expand Down
46 changes: 46 additions & 0 deletions tests/Select.loadData.spec.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
/* eslint-disable no-undef, react/no-multi-comp, no-console */
import React from 'react';
import { render, fireEvent, act } from '@testing-library/react';

import TreeSelect from '../src';

describe('TreeSelect.loadData', () => {
it('keep sync', async () => {
const Demo = () => {
const [treeData, setTreeData] = React.useState([
{
title: '0',
value: 0,
isLeaf: false,
},
]);

const loadData = async () => {
const nextId = treeData.length;

setTreeData([
...treeData,
{
title: `${nextId}`,
value: nextId,
isLeaf: false,
},
]);
};

return <TreeSelect open treeData={treeData} loadData={loadData} />;
};

render(<Demo />);

for (let i = 0; i < 5; i += 1) {
fireEvent.click(document.querySelector('.rc-tree-select-tree-switcher_close'));
await act(async () => {
await Promise.resolve();
});
expect(
document.querySelectorAll('.rc-tree-select-tree-list .rc-tree-select-tree-treenode'),
).toHaveLength(2 + i);
}
zombieJ marked this conversation as resolved.
Show resolved Hide resolved
});
});