Allow consumption of RCTAsyncStorage as TurboModule #965
Conversation
In react-native-windows, attributed C++ modules can be consumed as either a legacy native module or TurboModule. This change enables registration of RNCAsyncStorage as a TurboModule.
| // TurboModuleRegistry falls back to NativeModules so we don't have to try go | ||
| // assign NativeModules' counterparts if TurboModuleRegistry would resolve | ||
| // with undefined. | ||
| let RCTAsyncStorage = TurboModuleRegistry |
There was a problem hiding this comment.
I wonder if we should just bump the minimum requirement to 0.61 so we don't have to do this check. What do you think @krizzu?
There was a problem hiding this comment.
I'm fine with the change, although that means we'd have to keep a compatibility table in readme (so that, we show which version is supported by which RN version). I guess it's safe to say we support 0.60 and up version
There was a problem hiding this comment.
Okay, let's do this after this PR merges. Can you fix the Release job? It looks like it's unable to fetch user and password for some reason.
There was a problem hiding this comment.
Ah, I didn't realize this was an issue. Thanks for looking into it. I guess that means we can merge this now?
|
🎉 This PR is included in version 1.18.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
In react-native-windows, attributed C++ modules can be consumed as either a legacy native module or TurboModule. This change enables registration of RNCAsyncStorage as a TurboModule.
Test Plan
Tested this out in a react-native-windows C++ app, where instead of using the ReactPackageProvider, I register RNCAsyncStorage.h directly as a TurboModule.