Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Separate release action from PR action #972

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Conversation

krizzu
Copy link
Member

@krizzu krizzu commented Jun 6, 2023

Summary

Removing release Making sure release action is run only on push actions, so that it would not fail, due to lack of access to secrets.

Also, running TS/Lint in a matrix as a bonus

Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@krizzu krizzu enabled auto-merge (squash) June 6, 2023 08:58
@krizzu krizzu merged commit 8cfb51a into master Jun 19, 2023
@krizzu krizzu deleted the ci/release-action branch June 19, 2023 17:29
@AsyncStorageBot
Copy link
Collaborator

🎉 This PR is included in version 1.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants