fix: use variant arg in build-android command #1798
Conversation
|
Hey @adamTrz, after some conversation on issue #1796, I found that docs are not updated, see here. It can be confusing - #1796 (comment), and actually we've that in the codebase, here, so you could you please add info about that |
adamTrz
force-pushed
the
fix/use-variant-in-run-android-command
branch
from
c659e09 to
d2fa723
Compare
packages/cli-platform-android/src/commands/runAndroid/runOnAllDevices.ts
Outdated
Show resolved
Hide resolved
adamTrz
force-pushed
the
fix/use-variant-in-run-android-command
branch
from
d2fa723 to
d3ed617
Compare
| import tryLaunchEmulator from './tryLaunchEmulator'; | ||
| import tryInstallAppOnDevice from './tryInstallAppOnDevice'; | ||
| import {Flags} from '.'; | ||
| import {BuildFlags} from '../buildAndroid'; |
There was a problem hiding this comment.
now we have a circular reference between buildAndroid and runOnAllDevices
| export function getTaskNames( | ||
| appName: string, | ||
| commands: Array<string>, | ||
| args: BuildFlags, |
There was a problem hiding this comment.
I'm not a fan of leaking whole args to a helper function. Can we convert that into explicit arguments? Either as an object or a arg list, I'm fine with both
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
Let's fix that circular reference and getTaskNames fn signature and we can ship it
adamTrz
force-pushed
the
fix/use-variant-in-run-android-command
branch
from
d3ed617 to
0705f50
Compare
packages/cli-platform-android/src/commands/runAndroid/runOnAllDevices.ts
Show resolved
Hide resolved
|
@adamTrz please verify my latest updates and we're good to go :) |
4 participants
Summary:
Fixes: facebook/react-native#35838
If
variantis passed torun-androidcommand we still should respect it.Test Plan:
yarn react-native run-android --mode FullDebug --verboseshould output./gradlew app:installFullDebugyarn react-native run-android --variant FullDebug --verboseshould output./gradlew app:installFullDebugyarn react-native build-android --mode FullDebug --verboseshould output./gradlew app:assembleFullDebugyarn react-native build-android --variant FullDebug --verboseshould output./gradlew app:assembleFullDebug