fix: use variant arg in build-android command #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @adamTrz, after some conversation on issue #1796, I found that docs are not updated, see here. It can be confusing - #1796 (comment), and actually we've that in the codebase, here, so you could you please add info about that |
adamTrz
force-pushed
the
fix/use-variant-in-run-android-command
branch
from
c659e09
to
d2fa723
Compare
packages/cli-platform-android/src/commands/runAndroid/runOnAllDevices.ts
Outdated
Show resolved
Hide resolved
adamTrz
force-pushed
the
fix/use-variant-in-run-android-command
branch
from
d2fa723
to
d3ed617
Compare
thymikee
reviewed
Jan 17, 2023
| @@ -16,14 +16,17 @@ import tryLaunchAppOnDevice from './tryLaunchAppOnDevice'; | |||
| import tryLaunchEmulator from './tryLaunchEmulator'; | |||
| import tryInstallAppOnDevice from './tryInstallAppOnDevice'; | |||
| import {Flags} from '.'; | |||
| import {BuildFlags} from '../buildAndroid'; | |||
There was a problem hiding this comment.
now we have a circular reference between buildAndroid and runOnAllDevices
thymikee
reviewed
Jan 17, 2023
|
|
||
| export function getTaskNames( | ||
| appName: string, | ||
| commands: Array<string>, | ||
| args: BuildFlags, |
There was a problem hiding this comment.
I'm not a fan of leaking whole args to a helper function. Can we convert that into explicit arguments? Either as an object or a arg list, I'm fine with both
thymikee
requested changes
Jan 17, 2023
adamTrz
force-pushed
the
fix/use-variant-in-run-android-command
branch
from
d3ed617
to
0705f50
Compare
cortinico
reviewed
Jan 17, 2023
packages/cli-platform-android/src/commands/runAndroid/runOnAllDevices.ts
Show resolved
Hide resolved
thymikee
approved these changes
Jan 17, 2023
|
@adamTrz please verify my latest updates and we're good to go :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes: facebook/react-native#35838
If
variantis passed torun-androidcommand we still should respect it.Test Plan:
yarn react-native run-android --mode FullDebug --verboseshould output./gradlew app:installFullDebugyarn react-native run-android --variant FullDebug --verboseshould output./gradlew app:installFullDebugyarn react-native build-android --mode FullDebug --verboseshould output./gradlew app:assembleFullDebugyarn react-native build-android --variant FullDebug --verboseshould output./gradlew app:assembleFullDebug