Publish stripped libraries in default AAR #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
1. To reduce final APK size, publish stripped libjsc.so in dist/**/*.aar
2. The unstripped version is important for troubleshooting
especially crash backtrace symbalication.
Will publish unstripped version in dist.unstripped/**/*.aar
Summary:
The helper tool extract files from CircleCI stored dist.tgz.
And publish dist/ packages to jsc-android@{VERSION} with {TAG}
dist.unstripped/ to jsc-android@{VERSION}-unstripped with {TAG}-unstripped
Usage:
python scripts/publish.py -T {TAG} /path/to/dist.tgz [--dry-run]
E.g.
python scripts/publish.py -T next ~/Downloads/dist.tgz --dry-run
python scripts/publish.py -T latest ~/Downloads/dist.tgz
This was referenced Oct 2, 2019
wkozyra95
approved these changes
Oct 9, 2019
scripts/publish.py
Outdated
| @@ -0,0 +1,86 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
all scripts are in js or bash, is introducing python here really necessary?
If you don't want to deal with cmd parsing in bash you could always pass everything by env instead.
|
Is this going to be merged soon? I am planning on doing a custom JSC build and would love to have this to reduce the binary size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Originally, the published libjsc.so is unstripped.
If user does not installed NDK in the host, the generated APK will take extra binary size for debug symbols.
This PR will strip symbols in libjsc.so.
To help native crash troubleshooting, the unstripped version is also available.
This PR includes two major changes:
Publish stripped libraries in default AAR.
dist/**/*.aardist.unstripped/**/*.aarAdd npm publish helper tool
The helper tool extract files from CircleCI stored dist.tgz.
And publish
Usage:
./scripts/publish.js -T {TAG} /path/to/dist.tgz [--dry-run]E.g.
./scripts/publish.js -T next ~/Downloads/dist.tgz --dry-run./scripts/publish.js -T latest ~/Downloads/dist.tgz