Upgrade to WebKitGTK 2.26.1 #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
1. To reduce final APK size, publish stripped libjsc.so in dist/**/*.aar
2. The unstripped version is important for troubleshooting
especially crash backtrace symbalication.
Will publish unstripped version in dist.unstripped/**/*.aar
Summary:
The helper tool extract files from CircleCI stored dist.tgz.
And publish dist/ packages to jsc-android@{VERSION} with {TAG}
dist.unstripped/ to jsc-android@{VERSION}-unstripped with {TAG}-unstripped
Usage:
python scripts/publish.py -T {TAG} /path/to/dist.tgz [--dry-run]
E.g.
python scripts/publish.py -T next ~/Downloads/dist.tgz --dry-run
python scripts/publish.py -T latest ~/Downloads/dist.tgz
1. Update patches for WebKitGTK 2.26 2. cmake upgrades to 3.10 for WebKit upstream mininal requirements changes and remove some patches for original WebKit FindICU.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP PR and two commits are based on #123, will rebase once #123 getting merged.
Summary
Upgrade to NDK r19c as r17c the old clang had some build errors.
r19c removed the make_standalone_toolchain as it self is already the standalone toolchain.
https://developer.android.com/ndk/guides/other_build_systems
So the PR changed some toolchain commands.
WebKit upstream upgrade minimum supported cmake version and drop internal FindICU.cmake.
The PR upgrades to use cmake 3.10.
As NDK r19c + cmake 3.10,
CMAKE_SYSTEM_NAMEseems not worked.Use
CMAKE_TOOLCHAIN_FILE=${ANDROID_NDK}/build/cmake/android.toolchain.cmaketo specify explicitly build instruction instead.