Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added source gen tests for generic constraints #1859

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

TimothyMakkison
Copy link
Contributor

@TimothyMakkison TimothyMakkison commented Oct 3, 2024

Rel #1791

Will have to be updated after #1861

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.79%. Comparing base (6ebeda5) to head (bc16045).
Report is 123 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1859      +/-   ##
==========================================
- Coverage   87.73%   83.79%   -3.94%     
==========================================
  Files          33       36       +3     
  Lines        2348     2456     +108     
  Branches      294      346      +52     
==========================================
- Hits         2060     2058       -2     
- Misses        208      316     +108     
- Partials       80       82       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimothyMakkison
Copy link
Contributor Author

TimothyMakkison commented Oct 5, 2024

@ChrisPulman
Thanks for merging #1861, I've updated the tests to reflect the corrected version.

Regarding, never used it before but I've created an account with the same email address as the one I use for github. Not sure if I set it up correctly 😅

Otherwise if you need to contact me, I'm pretty responsive on github 👍

@ChrisPulman ChrisPulman merged commit faa1f68 into reactiveui:main Oct 5, 2024
2 of 3 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants