[BUG] ReflectionTypeLoadException - Type '__callback_factory__class__' is not finished #421
Labels
Comments
|
For posterity |
|
#330 might be related |
|
Can you get the call stack of the WriteLine statement writing |
|
Thank you for your prompt reply @anaisbetts This is what I get out of rider. It's happening the very first time I try to create a ReactiveCommand var loadDataCommand = ReactiveCommand.CreateFromTask<string>(LoadData);which is this line right here |
|
This seems to be a Xamarin regression - originally this was a simple reflection of getting a bunch of |
|
@ChaseFlorell If you're feeling Charitable, it'd be cool if you could figure out what is actually so expensive - is it that we're generating so many log lines? Is Xamarin actually loading all these images? A third thing?? |
|
Initial investigation showed that is near instant in release.
|
|
That doesn't explain the initial exception though.
Get Outlook for Android<https://aka.ms/ghei36>
…________________________________
From: Anaïs Betts <notifications@github.com>
Sent: Friday, November 1, 2019 5:15:09 PM
To: reactiveui/splat <splat@noreply.github.com>
Cc: Chase Florell <chase@flomedia.ca>; Mention <mention@noreply.github.com>
Subject: Re: [reactiveui/splat] [BUG] ReflectionTypeLoadException - Type '__callback_factory__class__' is not finished (#421)
@ChaseFlorell<https://github.com/ChaseFlorell> If you're feeling Charitable, it'd be cool if you could figure out what is actually so expensive - is it that we're generating so many log lines? Is Xamarin actually loading all these images? A third thing??
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#421?email_source=notifications&email_token=AADTESXMSABTQ67XLEKL7OTQRTBAZA5CNFSM4JH76EC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC4OX6I#issuecomment-548989945>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AADTESTMTJXMV53NHXLBECLQRTBAZANCNFSM4JH76ECQ>.
|
|
Out of curiosity, how many Assemblies do you have? |
|
uhhh, 208 😬
|
|
I've found the bug |
|
this is great news @anaisbetts, what can I do to help? |
|
I think she was referring to the high number of assemblies you are loading. You can probably use linking to reduce your assemblies down a lot. |
|
😂that's what I get for reviewing comments before my morning coffee. |
|
With reactiveui and splat you may want to set in your linking settings to exclude those two projects. Reason being we use a lot of reflection and linking won't see those. |
|
I still have to ask, if I'm just using ReactiveUI, why do I need to load all that drawing stuff? I won't be turning linking on in debug mode (where I see this error), and like I said above ,in a Release build it's much faster (near instant), probably because a) we do have linking enabled, and b) we're not writing a bazillion lines to the console. If we just have to live with it, we will. I was just hoping we'd have some way of turning this off, or optimizing it. |
|
We are considering just removing that functionality or at least making it optional |
Well that would be the bees knees! Thanks for all your hard work. |
|
would using Roslyn at compile time to generate an init class somewhat akin to how pharmacist works be a viable solution? or not much point? |
|
bug is still there in 10.5.31 |
|
That's why the issue is still open ;) |
|
I also faced the same problem. And the problem is even worse because I usually set my Visual Studio to always stop the debugger on each C# exception. And when I added ReactiveUI to my Xamarin Forms Android project, it blows up with lots of exceptions and I just have to disable stopping on each exceptions, which may result in missing something important happening in my app. Please, tell me how can I fix this on my own? I'd like to build my own NuGet without this bug. |
|
If you are using ReactiveUI you won't see this functionality now unless you add ReactiveUI.Drawing. Which may solve many users issue with this. |
|
been giving this some more thought as seeing speed issue in xunit test harness.
|
|
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
I just installed the latest ReactiveUI (10.5.7) into my Xamarin.Forms (4.3) app, and built a single ViewModel out using it. I love it so far, and I did all of my testing using the iOS simulator.
Upon testing the app on my Pixel 4XL (Android 10), I immediately got the following runtime exception when I hit the new page/viewmodel.
followed by a really long list of this
The end result is an extremely long delay in loading the page.
Steps To Reproduce
Not sure how to fill this in. I'm assuming this is a tooling issue moresoe than anything else. I will give whatever information you ask for however.
Expected behavior
Page should load instantaneously
Screenshots
If applicable, add screenshots to help explain your problem.
Environment(please complete the following information):
notice in the gif where I press the (+) in the top right, there is an enormous delay and an enormous amount of output before the page loads.
The text was updated successfully, but these errors were encountered: