Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#586 bitmap loader init perf fixes #598

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Conversation

dpvreony
Copy link
Member

@dpvreony dpvreony commented Sep 30, 2020

What kind of change does this PR introduce?
bug fix of poor perf in platform bitmap loader init during debug

closes #586
closes #421

What is the current behavior?
mass debug lines on xamarin debugger means initialisation is slow and gives poor experience

What is the new behavior?
uses stringbuilder and parallel assembly searching.

What might this PR break?
stringbuilder might get big, debug output is now single large burst

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@dpvreony dpvreony requested a review from a team September 30, 2020 23:35
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #598 into main will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #598   +/-   ##
=======================================
  Coverage   67.12%   67.13%           
=======================================
  Files          85       85           
  Lines        4170     4171    +1     
  Branches      416      416           
=======================================
+ Hits         2799     2800    +1     
  Misses       1285     1285           
  Partials       86       86           
Impacted Files Coverage Δ
...ing/Platforms/net4/Bitmaps/PlatformBitmapLoader.cs 52.00% <0.00%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de3466d...18a3fb4. Read the comment docs.

@glennawatson glennawatson merged commit 92b41f9 into main Oct 1, 2020
@glennawatson glennawatson deleted the bitmaploaderinitperf branch October 1, 2020 01:12
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants