Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components and Props translation #10

Merged
merged 11 commits into from
Feb 2, 2019
Merged

Components and Props translation #10

merged 11 commits into from
Feb 2, 2019

Conversation

EzequielMonforte
Copy link
Contributor

@EzequielMonforte EzequielMonforte commented Jan 31, 2019 •
edited by alejandronanez
Loading

Components and props
Related to #4

@EzequielMonforte EzequielMonforte changed the title WIP Components and Props WIP Components and Props translation Jan 31, 2019
@tesseralis tesseralis mentioned this pull request Jan 31, 2019
Closed
@EzequielMonforte EzequielMonforte changed the title WIP Components and Props translation Components and Props translation Jan 31, 2019
@EzequielMonforte
Copy link
Contributor Author

Corrections applied

alejandronanez
alejandronanez reviewed Feb 1, 2019
View reviewed changes
Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @EzequielMonforte, I left some comments that are worth addressing before merging this PR.

Thanks!

content/docs/components-and-props.md Outdated Show resolved Hide resolved
content/docs/components-and-props.md Outdated Show resolved Hide resolved
content/docs/components-and-props.md Outdated Show resolved Hide resolved
content/docs/components-and-props.md Outdated Show resolved Hide resolved
content/docs/components-and-props.md Outdated Show resolved Hide resolved
content/docs/components-and-props.md Outdated Show resolved Hide resolved
alejandronanez
alejandronanez approved these changes Feb 2, 2019
View reviewed changes
Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @EzequielMonforte, thanks for addressing all the comments in record time!

This is looking good - thanks for contributing!

@alejandronanez alejandronanez merged commit a4efd8e into reactjs:master Feb 2, 2019
@EzequielMonforte EzequielMonforte deleted the translate-components-props branch February 2, 2019 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricglz ricglz ricglz left review comments

@gariasf gariasf gariasf left review comments

@carburo carburo carburo left review comments

@sergiodxa sergiodxa sergiodxa left review comments

@alejandronanez alejandronanez alejandronanez approved these changes

@dmoralesm dmoralesm Awaiting requested review from dmoralesm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@EzequielMonforte @alejandronanez @sergiodxa @carburo @gariasf @ricglz