Translate: Typechecking With PropTypes #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnosornov
changed the title
RamirezAlex
reviewed
Feb 7, 2019
RamirezAlex
reviewed
Feb 7, 2019
RamirezAlex
reviewed
Feb 7, 2019
RamirezAlex
reviewed
Feb 7, 2019
RamirezAlex
reviewed
Feb 7, 2019
|
Thank you @jnosornov! Great job! LGTM 👍 |
alejandronanez
requested changes
Feb 7, 2019
There was a problem hiding this comment.
@jnosornov 👋 great work so far!
There are 4 changes that need to be made before merging this!
Thanks for your effort!
Also, thanks @RamirezAlex for reviewing this work! 👍
alejandronanez
approved these changes
Feb 8, 2019
There was a problem hiding this comment.
Awesome @jnosornov, thanks for addressing all these changes! Also, welcome to the project!
Merging this now!!!!
|
thanks guys for the review @RamirezAlex and @alejandronanez. Now move on! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to issue #4.
Have some doubts about some therminology translation.
Check out the PR and let me know.