Translate Higher Order Components #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
icarlossz
suggested changes
Feb 8, 2019
Contributor
icarlossz
left a comment
icarlossz
left a comment
There was a problem hiding this comment.
Good job! I left you some comments! 👍
Contributor
Author
|
Thanks @icarlossz for your reviews, I merged some and left comments on the others |
Contributor
|
Thanks! I learned a lot in this PR 😅 |
icarlossz
approved these changes
Feb 8, 2019
Contributor
Author
|
Hey @RamirezAlex, @carburo will you take a look at this translation? I appreciate your comments from previous translations and I think this one will benefit from an extra pair of eyes. |
RamirezAlex
reviewed
Feb 8, 2019
Contributor
RamirezAlex
left a comment
RamirezAlex
left a comment
There was a problem hiding this comment.
Good work in general, I only that small type and the missing comma :)
Contributor
Author
|
@carburo @alejandronanez I think this is ready for merging |
carburo
reviewed
Feb 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.