Translate: Strict mode #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonalvarezz
reviewed
Feb 9, 2019
jonalvarezz
reviewed
Feb 9, 2019
jonalvarezz
reviewed
Feb 9, 2019
jonalvarezz
reviewed
Feb 9, 2019
jonalvarezz
reviewed
Feb 9, 2019
jonalvarezz
reviewed
Feb 9, 2019
|
Great job David 😁! I've added some comments. |
|
Thanks Jonathan! I just made a commit applying those comments. |
alejandronanez
requested changes
Feb 12, 2019
There was a problem hiding this comment.
Hey @d4vsanchez, thanks for working on this, this PR is looking reaaally good, just left a couple of minor comments that I think we should address before merging.
If you think that my suggestions don't apply, just let me know, we can talk about it!
Thanks again for your contribution!
| * `constructor` | ||
| * `componentWillMount` | ||
| * `componentWillReceiveProps` | ||
| * `componentWillUpdate` | ||
| * `getDerivedStateFromProps` | ||
| * `shouldComponentUpdate` | ||
| * `render` | ||
| * `setState` updater functions (the first argument) | ||
| * Funciones de actualización de `setState` (el primer argumento) |
There was a problem hiding this comment.
I don't understand this one, is it OK? haha
There was a problem hiding this comment.
haha it sounds good I think 😂
|
Hey @alejandronanez, they were very valuable! I have made a new commit applying those suggestions and also modifying the "Advertencia" in the bullet points section.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've done translating
Strict modeto Spanish. #4I'm having some doubts with some stuff in the translation and I hope you can help me with them if you have a better way to translate it:
fase de confirmación.string ref,callback ref,object ref. I've basically left them as is; I can instead translate themreferencia de string(to comply with the translation guideline table),referencia de objetoandreferencia de callback. What do you think it's better?cc: @alejandronanez @dmoralesm @carburo