-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the traslation for Portals #131
Merged
carburo
merged 3 commits into
reactjs:master
from
khriztianmoreno:feature/translate-portals
Feb 11, 2019
Merged
Add the traslation for Portals #131
carburo
merged 3 commits into
reactjs:master
from
khriztianmoreno:feature/translate-portals
Feb 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonalvarezz
reviewed
Feb 9, 2019
jonalvarezz
reviewed
Feb 9, 2019
jonalvarezz
reviewed
Feb 9, 2019
jonalvarezz
reviewed
Feb 9, 2019
jonalvarezz
reviewed
Feb 9, 2019
jonalvarezz
reviewed
Feb 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 🔥
Added some reviews.
khriztianmoreno
force-pushed
the
feature/translate-portals
branch
from
February 9, 2019 15:13
af2cd18
to
6d32365
Compare
Thank you! Looks good. I just fixed a few typos and changed the use of usted->tú (Check the style guide). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translating Portals section of the API Reference to Spanish. 📝 🌎