Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Top-Level API Spanish Translation #139

Merged
merged 3 commits into from
Feb 12, 2019

Conversation

karolincastano
Copy link
Contributor

@karolincastano karolincastano commented Feb 10, 2019

This is the translation for the React Top-Level API page, assigned to me on issue #4

@carburo
Copy link
Member

carburo commented Feb 10, 2019

Hi, @karolincastano! Check the translation guide. You shouldn't translate heading IDs.

@karolincastano karolincastano changed the title WIP: React Top-Level API Spanish Translation React Top-Level API Spanish Translation Feb 12, 2019
@karolincastano
Copy link
Contributor Author

Hi @alejandronanez, @carburo, @dmoralesm I've updated this PR with the latest changes. Also, I restored the heading IDs to their original form.

@carburo carburo self-assigned this Feb 12, 2019
Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Very solid PR. I just fixed a typo and changed

  • librería -> biblioteca
  • componente función -> componente de función

not because your choices are wrong but because these are the terms we are using for consistency among all articles. Looking forward to another PR. Ready to be merged. 🚀

@@ -13,43 +13,43 @@ redirect_from:
- "docs/top-level-api-zh-CN.html"
---

`React` is the entry point to the React library. If you load React from a `<script>` tag, these top-level APIs are available on the `React` global. If you use ES6 with npm, you can write `import React from 'react'`. If you use ES5 with npm, you can write `var React = require('react')`.
`React` es el punto de entrada a la librería de React. Si se carga React desde una etiqueta `<script>`, estas API de alto nivel estarán disponibles en el `React` global. Si se usa ES6 con npm se puede escribir `import React from 'react'`. Si se usa ES5 con npm, se puede escribir `var React = require('react')`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Para lograr consistencia entre los artículos estamos utilizando en todos «biblioteca» como traducción de «library» (puedes encontrarlo en la guía de traducción).

Suggested change
`React` es el punto de entrada a la librería de React. Si se carga React desde una etiqueta `<script>`, estas API de alto nivel estarán disponibles en el `React` global. Si se usa ES6 con npm se puede escribir `import React from 'react'`. Si se usa ES5 con npm, se puede escribir `var React = require('react')`.
`React` es el punto de entrada a la biblioteca de React. Si se carga React desde una etiqueta `<script>`, estas API de alto nivel estarán disponibles en el `React` global. Si se usa ES6 con npm se puede escribir `import React from 'react'`. Si se usa ES5 con npm, se puede escribir `var React = require('react')`.

content/docs/reference-react.md Outdated Show resolved Hide resolved
@carburo carburo merged commit 23e9671 into reactjs:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants