Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate: Add React to a website #148

Merged
merged 2 commits into from
Feb 13, 2019
Merged

Translate: Add React to a website #148

merged 2 commits into from
Feb 13, 2019

Conversation

d4vsanchez
Copy link
Contributor

I've done translating Add React to a Website. #4

cc: @alejandronanez @carburo @dmoralesm

@alejandronanez alejandronanez self-requested a review February 12, 2019 23:41
Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @d4vsanchez, thanks for another solid PR!

I left a couple of comments though, let me know what you think!

Thanks!

content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
@d4vsanchez
Copy link
Contributor Author

@alejandronanez Thanks!

I'd be more than happy to use minificar. But, we'll have to add an exception for it on the table of the TRANSLATIONS.md file as that word doesn't exist in Spanish. What do you think?

I agree on the use of minificar, though.

@alejandronanez
Copy link
Member

@d4vsanchez don't we facepalms? Let's go with compactar then!

@d4vsanchez
Copy link
Contributor Author

@alejandronanez Haha! No problem. Thanks!

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s go!

@alejandronanez alejandronanez merged commit 25e4e67 into reactjs:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants