-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translating how to contribute section. #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Thank you for your contribution.
Check this before doing a full review.
- It would be better if you could change your lines to match the original. It makes our lives easier when reviewing.
- I noticed you are using "usted" conjugations for the 2nd person singular, you should change it to "tú" as described in the style guide.
- Don't add the nav file. It is already translated.
Deploy preview for es-reactjs ready! Built with commit eb1c937 |
Deploy preview for es-reactjs ready! Built with commit ef3a998 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thank you again for your contribution. I made some suggestions. Many of them related to the use of «usted» (Check our style guide for more information on this matter). Let us know if you need help with this.
Hello @maudel. It has been 13 days since the first request for changes. Are you able to check it? Let me know if you don't have enough time. I could help in editing so this can be merged. |
I applied the changes myself. I think this is good to go. Thanks! |
Translation:
Contributing
@alejandronanez, @carburo, @dmoralesm
Please let me know if everything is looking good.