Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate LayoutFooter and LayoutHeader #160

Merged
merged 8 commits into from
Feb 17, 2019
Merged

Translate LayoutFooter and LayoutHeader #160

merged 8 commits into from
Feb 17, 2019

Conversation

Zitle-Nancy
Copy link
Contributor

No description provided.

@Zitle-Nancy Zitle-Nancy mentioned this pull request Feb 16, 2019
Closed
@carburo carburo self-requested a review February 17, 2019 00:15
@carburo carburo mentioned this pull request Feb 17, 2019
Closed
10 tasks
icarlossz
icarlossz suggested changes Feb 17, 2019
View reviewed changes
Copy link
Contributor

@icarlossz icarlossz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I left you some comments :)

content/community/nav.yml Outdated Show resolved Hide resolved
content/docs/nav.yml Outdated Show resolved Hide resolved
content/docs/nav.yml Outdated Show resolved Hide resolved
content/docs/nav.yml Outdated Show resolved Hide resolved
carburo
carburo approved these changes Feb 17, 2019
View reviewed changes
Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks again! I just made some (mostly cosmetic) changes directly as we are trying to have this part of the site translated ASAP.

@carburo carburo merged commit fca4773 into reactjs:master Feb 17, 2019
@Zitle-Nancy
Copy link
Contributor Author

You're welcome, It was a pleasure , if you need anything else just let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icarlossz icarlossz icarlossz requested changes

@carburo carburo carburo approved these changes

Assignees
No one assigned
Labels
has-reviewer needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zitle-Nancy @carburo @icarlossz