-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translated render-props #182
Conversation
Deploy preview for es-reactjs ready! Built with commit 5ba9be0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greetings @jonathanpalma ! Thank you for a great job! 🚀
I left you some comments, it's really good in general, just take back to english some code parts that we're not translating, a little typo and some changes to give a clearer reading. Please let me know for any questions or when you have those 💪 Then we'd be good to go 🥇
content/docs/render-props.md
Outdated
@@ -42,22 +42,22 @@ class MouseTracker extends React.Component { | |||
render() { | |||
return ( | |||
<div style={{ height: '100%' }} onMouseMove={this.handleMouseMove}> | |||
<h1>Move the mouse around!</h1> | |||
<p>The current mouse position is ({this.state.x}, {this.state.y})</p> | |||
<h1>¡Mueve el cursor alrededor!</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<h1>¡Mueve el cursor alrededor!</h1> | |
<h1>Move the mouse around!</h1> |
Co-Authored-By: jonathanpalma <tanpalma04@gmail.com>
Co-Authored-By: jonathanpalma <tanpalma04@gmail.com>
Co-Authored-By: jonathanpalma <tanpalma04@gmail.com>
Co-Authored-By: jonathanpalma <tanpalma04@gmail.com>
Co-Authored-By: jonathanpalma <tanpalma04@gmail.com>
Co-Authored-By: jonathanpalma <tanpalma04@gmail.com>
Hey @Darking360, thanks for your review, I already updated all the changes you recommended, could you please check again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! I suggested a few changes and typos. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jonathanpalma!
Thanks for your contribution, I left some extra comments here that are worth addressing before merging!
This is looking great so far, thanks for all your hard work!
Co-Authored-By: jonathanpalma <tanpalma04@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greetings @jonathanpalma 🌞
Thanks for addressing the changes from the guys, I saw some markdown issues and an accent left but I added those so no worries 💪 Thanks for the great work, you rock! 🚀
No description provided.