Conditional Rendering translation #19
Conversation
ElRodrigote
changed the title
…word translation.
…ations and proof reading.
… for Code Review.
|
@alejandronanez I finished the translation, but don't know how to add people to this PR so they can review it. |
ElRodrigote
changed the title
There was a problem hiding this comment.
Hey @ElRodrigote, thanks for this PR.
I think we need to change a couple of things before merging it.
- You translated almost all the code, but right now it is completely different to the one in the codepen link. Please roll back it to English so everything is in sync.
- I see you added an
$INLINEword in the translation, what is it for? I suggested some translation for it, but I'm not 100% if it satisfies what we want to communicate. We're open to suggestions about that$INLINE.
Let us know if you have any question,
Thanks!
|
|
||
| ### Inline If with Logical && Operator | ||
| ### If $INLINE con operador lógico && |
There was a problem hiding this comment.
What does this inline stand out for?
There was a problem hiding this comment.
If we are not translating $INLINE, I think we could say en la misma línea or something similar.
There was a problem hiding this comment.
That title refers to the use of things like {isVisible && <Component />}. That's an inline if operator, simpler and easier to read than traditional block based or ternary ones, specially useful inside of JSX expressions. Just FYI.
If isVisible is false, the statement will return false and therefore <Component /> won't render and vice-versa.
There was a problem hiding this comment.
Gotcha. Will take a look at that and translated snippet @123
| ); | ||
| ``` | ||
|
|
||
| [**Try it on CodePen**](https://codepen.io/gaearon/pen/ozJddz?editors=0010) | ||
| [**Pruébalo en CodePen**](https://codepen.io/gaearon/pen/ozJddz?editors=0010) |
There was a problem hiding this comment.
Please update the code in lines 127-147 to match this codepen link as much as possible. I think it's fine to change the content of the JSX but not the component names neither the root node.
Thanks for the review! |
…$INLINE flagged word
|
@alejandronanez thanks for the CR, I think I've addressed all of them :) |
…MDN documentation.
…xed. All accent marks reviewed.
|
@gariasf Thanks for the CR, all the file was just reviewed, I think it's good to go now :), but please take a final look if you guys have the time to with @alejandronanez |
…tional-rendering-translation
There was a problem hiding this comment.
Hey @ElRodrigote, almost there!
Please update your PR with the suggestions, all code should remain in English. Thanks for the hard work (and your patience) 💪 !
…ed spanish grammar again. Minor changes.
There was a problem hiding this comment.
LGTM @ElRodrigote, thanks for being a contributor! 👍
Welcome, keep the PRs coming!
Related with #17