Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate SyntheticEvent #29

Merged
merged 38 commits into from
Feb 2, 2019

Conversation

Cavallando
Copy link
Contributor

Translation of SyntheticEvent section. Had a lot of help from my friend who speaks Spanish as his first language, please let me know anything that you think might need some help!

Referencing Issue: #26

@Cavallando
Copy link
Contributor Author

Github is not allowing me to assign, I believe due to permissions (unless I am missing something dumb). Want to make sure I am following the contributing guidelines, hopefully this comment is acceptable form of assigning! @dmoralesm, @carburo and @alejandronanez

@alejandronanez
Copy link
Member

Hey @michaelcavallaro03, thanls for this PR! Welcome 👏

You're not dumb (please don't say that), you just don't have enough permissions. I'll set that up for you, thanks again!

Copy link
Contributor

@hugmanrique hugmanrique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some incorrect translations and typos, but this PR looks pretty good!

Thanks for your work 😊

content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
EzequielMonforte and others added 12 commits February 1, 2019 11:40
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@hugmanrique
Copy link
Contributor

hugmanrique commented Feb 1, 2019

Fixed the event name suggestions, thanks gariasf 😜

hugmanrique and others added 7 commits February 1, 2019 12:56
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
hugmanrique and others added 8 commits February 1, 2019 13:12
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@Cavallando
Copy link
Contributor Author

Thank you all for your comments and your work reviewing/translating overall! I added the changes that you all discussed/requested. Please let me know if there is anything else necessary to change!

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @michaelcavallaro03,

Thanks for your PR, this is getting close to what we want!

I'm requesting changes because of this https://github.com/reactjs/es.reactjs.org/pull/29/files#diff-551c454828b77e72a3859b9731768e7eR250

Let us know if you need help with anything else!

content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
alejandronanez and others added 7 commits February 1, 2019 17:12
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
@Cavallando
Copy link
Contributor Author

Committed your suggestions @alejandronanez as well as removed that silly usage of React as a verb and kept polyfill as is!

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @michaelcavallaro03, thanks for your contribution!

Merging!

@alejandronanez alejandronanez merged commit 465759d into reactjs:master Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants