-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate SyntheticEvent #29
Translate SyntheticEvent #29
Conversation
Github is not allowing me to assign, I believe due to permissions (unless I am missing something dumb). Want to make sure I am following the contributing guidelines, hopefully this comment is acceptable form of assigning! @dmoralesm, @carburo and @alejandronanez |
Hey @michaelcavallaro03, thanls for this PR! Welcome 👏 You're not dumb (please don't say that), you just don't have enough permissions. I'll set that up for you, thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some incorrect translations and typos, but this PR looks pretty good!
Thanks for your work 😊
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Fixed the event name suggestions, thanks gariasf 😜 |
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
…cavallaro03/es.reactjs.org into translate-syntheticevent
Thank you all for your comments and your work reviewing/translating overall! I added the changes that you all discussed/requested. Please let me know if there is anything else necessary to change! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @michaelcavallaro03,
Thanks for your PR, this is getting close to what we want!
I'm requesting changes because of this https://github.com/reactjs/es.reactjs.org/pull/29/files#diff-551c454828b77e72a3859b9731768e7eR250
Let us know if you need help with anything else!
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Co-Authored-By: michaelcavallaro03 <michaelcavallaro03@gmail.com>
Committed your suggestions @alejandronanez as well as removed that silly usage of React as a verb and kept polyfill as is! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @michaelcavallaro03, thanks for your contribution!
Merging!
Translation of SyntheticEvent section. Had a lot of help from my friend who speaks Spanish as his first language, please let me know anything that you think might need some help!
Referencing Issue: #26