Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building your Own Hooks Translation #34

Merged
merged 2 commits into from
Feb 5, 2019

Conversation

EzequielMonforte
Copy link
Contributor

@EzequielMonforte EzequielMonforte commented Feb 1, 2019

Closes #31

content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
@carburo
Copy link
Member

carburo commented Feb 2, 2019

@EzequielMonforte Thanks! I made some suggestions that I think need to be addressed before merging.

@gariasf
Copy link

gariasf commented Feb 2, 2019

Hey, I also replied to some of @carburo's comments with new suggestions, so please check those out again.

@EzequielMonforte
Copy link
Contributor Author

Thanks @gariasf and @carburo for your suggestions. I've been working with them

@carburo carburo reopened this Feb 5, 2019
@carburo carburo merged commit 08c7793 into reactjs:master Feb 5, 2019
@carburo
Copy link
Member

carburo commented Feb 5, 2019

Ok, now is merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants