-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate hooks-state #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @a13marquez, I see that some paragraphs are not being translated yet. I assume this PR is in WIP state still.
I updated the title of the PR to reflect this, once you're done, please, remove the WIP
part of the title.
Ps. I didn't finish my review since this looks to be in progress.
@@ -28,11 +29,11 @@ function Example() { | |||
} | |||
``` | |||
|
|||
We'll start learning about Hooks by comparing this code to an equivalent class example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened to this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
|
||
If you used classes in React before, this code should look familiar: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, what happened to this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@@ -56,15 +57,14 @@ class Example extends React.Component { | |||
} | |||
``` | |||
|
|||
The state starts as `{ count: 0 }`, and we increment `state.count` when the user clicks a button by calling `this.setState()`. We'll use snippets from this class throughout the page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to translate this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Yes, it is in progress, I forgot the WIP status, sorry. I will finish the translation and let you know |
And also I have a doubt about the comments inside the code. Should I translate them? |
@a13marquez Yes, it is ok to translate comments, but not anything else inside code blocks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @a13marquez, this is looking good, just left a minor comment that I think we should address before merging.
Also, it seems that we have merge conflicts, please, make sure to fix them too!
Thanks!!!
Deploy preview for es-reactjs ready! Built with commit db1a66b |
Deploy preview for es-reactjs ready! Built with commit 2f9a7df |
No description provided.