Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate: React Components #61

Merged

Conversation

semoal
Copy link
Contributor

@semoal semoal commented Feb 3, 2019

Translate of React Component done with Crowdin, you can check it out there.

@semoal semoal changed the title translated done Translate: React Components Feb 3, 2019
Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @semoal, thanks for your PR!

I almost stopped reviewing this PR right after line 145, there is a lot of spaces in the translation that makes me harder to review this side by side (English <-> Spanish) you mind running prettier to get the formatted version so it makes our lives easier?

Also, regarding code snippets, you should leave the code the same, but translate the comments.

Please, let us know when this is done so we can take another 👁

Thanks again,

content/docs/reference-react-component.md Outdated Show resolved Hide resolved
content/docs/reference-react-component.md Outdated Show resolved Hide resolved
content/docs/reference-react-component.md Outdated Show resolved Hide resolved
content/docs/reference-react-component.md Outdated Show resolved Hide resolved
content/docs/reference-react-component.md Outdated Show resolved Hide resolved
content/docs/reference-react-component.md Outdated Show resolved Hide resolved
content/docs/reference-react-component.md Outdated Show resolved Hide resolved
content/docs/reference-react-component.md Outdated Show resolved Hide resolved
content/docs/reference-react-component.md Outdated Show resolved Hide resolved
content/docs/reference-react-component.md Outdated Show resolved Hide resolved
Sergio Moreno and others added 3 commits February 3, 2019 23:52
Co-Authored-By: semoal <sergiomorenoalbert@gmail.com>
Co-Authored-By: semoal <sergiomorenoalbert@gmail.com>
Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@semoal Please, we're using across the repo, I saw you're using usted instead, can you please change this whenever you have a chance?

Thanks!

@tesseralis
Copy link
Member

Hi @semoal, what's the status of this PR? Are you ready for another review?

@semoal
Copy link
Contributor Author

semoal commented Feb 11, 2019

Hi @semoal, what's the status of this PR? Are you ready for another review?

Yeah, revised all "usted" and didn't find any.

So I think, it's all ok now. If not, i'll fix the issues tonight!

@tesseralis
Copy link
Member

Yay! @alejandronanez could you review again?

@alejandronanez
Copy link
Member

alejandronanez commented Feb 11, 2019

Hey @tesseralis and @semoal I’ll take a look tonight! ✌🏼

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @semoal, thanks for the updates, but this PR still needs a lot of work, please, avoid copying and pasting Crowdin's translations, as they could be outdated and/or be misleading (like this one - we even got some <li> tags that don't belong to this document at all.)

Also, there are some pieces of the document that still need to be translated.

Please, let us know when this is ready for another review.

Thanks!

content/docs/reference-react-component.md Outdated Show resolved Hide resolved
content/docs/reference-react-component.md Outdated Show resolved Hide resolved
content/docs/reference-react-component.md Outdated Show resolved Hide resolved
content/docs/reference-react-component.md Outdated Show resolved Hide resolved
content/docs/reference-react-component.md Outdated Show resolved Hide resolved
content/docs/reference-react-component.md Outdated Show resolved Hide resolved
content/docs/reference-react-component.md Outdated Show resolved Hide resolved
content/docs/reference-react-component.md Outdated Show resolved Hide resolved
content/docs/reference-react-component.md Outdated Show resolved Hide resolved
content/docs/reference-react-component.md Outdated Show resolved Hide resolved
@semoal
Copy link
Contributor Author

semoal commented Feb 12, 2019

I'll review all your comments in a while mate.
What a disaster was using crowdin as base :(

alejandronanez and others added 6 commits February 12, 2019 17:28
Co-Authored-By: semoal <sergiomorenoalbert@gmail.com>
Co-Authored-By: semoal <sergiomorenoalbert@gmail.com>
Co-Authored-By: semoal <sergiomorenoalbert@gmail.com>
WIP: Working on the translate of new texts

Co-Authored-By: semoal <sergiomorenoalbert@gmail.com>
@semoal
Copy link
Contributor Author

semoal commented Feb 12, 2019

@alejandronanez @dmoralesm ready for another review!!
Let it go!

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @semoal, thanks for addressing all the changes so fast!

This is looking good now, merging!

@alejandronanez alejandronanez merged commit b2b9577 into reactjs:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants