-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate: React Components #61
Translate: React Components #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @semoal, thanks for your PR!
I almost stopped reviewing this PR right after line 145, there is a lot of spaces
in the translation that makes me harder to review this side by side (English <-> Spanish
) you mind running prettier to get the formatted version so it makes our lives easier?
Also, regarding code snippets, you should leave the code the same, but translate the comments.
Please, let us know when this is done so we can take another 👁
Thanks again,
Co-Authored-By: semoal <sergiomorenoalbert@gmail.com>
Co-Authored-By: semoal <sergiomorenoalbert@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@semoal Please, we're using tú
across the repo, I saw you're using usted
instead, can you please change this whenever you have a chance?
Thanks!
Hi @semoal, what's the status of this PR? Are you ready for another review? |
Yeah, revised all "usted" and didn't find any. So I think, it's all ok now. If not, i'll fix the issues tonight! |
Yay! @alejandronanez could you review again? |
Hey @tesseralis and @semoal I’ll take a look tonight! ✌🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @semoal, thanks for the updates, but this PR still needs a lot of work, please, avoid copying and pasting Crowdin
's translations, as they could be outdated and/or be misleading (like this one - we even got some <li>
tags that don't belong to this document at all.)
Also, there are some pieces of the document that still need to be translated.
Please, let us know when this is ready for another review.
Thanks!
I'll review all your comments in a while mate. |
Co-Authored-By: semoal <sergiomorenoalbert@gmail.com>
Co-Authored-By: semoal <sergiomorenoalbert@gmail.com>
Co-Authored-By: semoal <sergiomorenoalbert@gmail.com>
WIP: Working on the translate of new texts Co-Authored-By: semoal <sergiomorenoalbert@gmail.com>
@alejandronanez @dmoralesm ready for another review!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @semoal, thanks for addressing all the changes so fast!
This is looking good now, merging!
Translate of React Component done with Crowdin, you can check it out there.