-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using the Effect Hook #66
Conversation
👋 @escorponox welcome to this project. Is this your PR still in progress? I see a lot of translated content but the title says Thanks! |
There is still a lot of content to be translated. I will remove the [WIP] once it is finished. Thanks!!! |
Ready for review. @alejandronanez @carburo @dmoralesm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a big one. Really good job!
I pointed out some small issues that should be addressed before merging.
Co-Authored-By: escorponox <escorponox@gmail.com>
Co-Authored-By: escorponox <escorponox@gmail.com>
Co-Authored-By: escorponox <escorponox@gmail.com>
Co-Authored-By: escorponox <escorponox@gmail.com>
Co-Authored-By: escorponox <escorponox@gmail.com>
Co-Authored-By: escorponox <escorponox@gmail.com>
Co-Authored-By: escorponox <escorponox@gmail.com>
Co-Authored-By: escorponox <escorponox@gmail.com>
@carburo I think all issues are fixed. |
content/docs/hooks-effect.md
Outdated
> | ||
>Eagle-eyed readers may notice that this example also needs a `componentDidUpdate` method to be fully correct. We'll ignore this for now but will come back to it in a [later section](#explanation-why-effects-run-on-each-update) of this page. | ||
>Los lectores avispados podrán percatarse de que este ejemplo necesita también un método `componentDidUpdate` para ser completamente correcto. De momento vamos a ignorar este hecho, pero volveremos a él en una [sección posterior](#explanation-why-effects-run-on-each-update) de esta página. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No biggie, but I think that detallistas
sounds a bit better than avispados
.
What do you think?
>Los lectores avispados podrán percatarse de que este ejemplo necesita también un método `componentDidUpdate` para ser completamente correcto. De momento vamos a ignorar este hecho, pero volveremos a él en una [sección posterior](#explanation-why-effects-run-on-each-update) de esta página. | |
>Los lectores detallistas podrán percatarse de que este ejemplo necesita también un método `componentDidUpdate` para ser completamente correcto. De momento vamos a ignorar este hecho, pero volveremos a él en una [sección posterior](#explanation-why-effects-run-on-each-update) de esta página. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perspicaces
may fit better imho. Do you agree? detallista
is used for personal relationships in Spain
No description provided.