Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate: Create a New React App #68

Merged
merged 22 commits into from
Feb 5, 2019

Conversation

elyalvarado
Copy link
Contributor

Done with the translation for Create a New React App #63.

Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @elyalvarado. Thank you for your contribution. I made some suggestions before merging.

content/docs/create-a-new-react-app.md Show resolved Hide resolved
content/docs/create-a-new-react-app.md Show resolved Hide resolved

This page describes a few popular React toolchains which help with tasks like:
Esta página describe algunas cadenas de herramientas de React populares, las cuales ayudan con tareas como:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Esta página describe algunas cadenas de herramientas de React populares, las cuales ayudan con tareas como:
Esta página describe algunas populares cadenas de herramientas de React, las cuales ayudan con tareas como:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most common order for the adjective in Spanish is after the noun.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo sé, pero hice la sugerencia porque la frase modificada por «populares» (cadenas de herramientas de React) hace un poco ambigua la frase: ¿Son populares las herramientas o las cadenas?

Copy link
Contributor Author

@elyalvarado elyalvarado Feb 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case: "cadenas de herramientas de React" is the noun. Maybe the following wording is clearer:

  • Esta página describe algunas de las cadenas de herramientas de React más populares ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I would go with that.

content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
carburo and others added 13 commits February 5, 2019 14:14
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
@elyalvarado
Copy link
Contributor Author

@carburo I added some of the changes you requested, but in some others I respectfully disagree. Please check the comments and let me know.
There is also no info regarding wether I should squash the commit or not.

@elyalvarado
Copy link
Contributor Author

elyalvarado commented Feb 5, 2019 via email

@carburo
Copy link
Member

carburo commented Feb 5, 2019

Ok, I am going to squash and merge. Sorry, we do not have a proper style guide nor a contribution guide yet. We are working on it.

@carburo carburo merged commit 3e28edb into reactjs:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants