Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Warnings (Special props && unknown-prop ) #69

Merged
merged 5 commits into from
Feb 10, 2019
Merged

Translate Warnings (Special props && unknown-prop ) #69

merged 5 commits into from
Feb 10, 2019

Conversation

jvelezpo
Copy link
Contributor

@jvelezpo jvelezpo commented Feb 4, 2019

Relates to #36

  • Special props doc translated
  • unknown-prop translated

@jvelezpo jvelezpo changed the title Warnings Translate Warnings (Special props && unknown-prop ) Feb 4, 2019
Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jvelezpo, thanks again for another contribution to the repo 🎉!

Could you please change the wording, from usted to please.

This is getting cloooose!

content/warnings/special-props.md Outdated Show resolved Hide resolved
content/warnings/unknown-prop.md Outdated Show resolved Hide resolved
alejandronanez and others added 2 commits February 6, 2019 18:58
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
@jvelezpo
Copy link
Contributor Author

jvelezpo commented Feb 7, 2019

@alejandronanez made the changes 👍

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jvelezpo, I left a comment that is worth addressing before merging,

Thanks!

content/warnings/unknown-prop.md Outdated Show resolved Hide resolved
@carburo carburo merged commit 6185a04 into reactjs:master Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants