Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate: Test Utilities #73

Merged
merged 2 commits into from
Feb 6, 2019
Merged

Translate: Test Utilities #73

merged 2 commits into from
Feb 6, 2019

Conversation

d4vsanchez
Copy link
Contributor

I've done translating Test Utilities to Spanish. #4 @alejandronanez @dmoralesm @carburo

I'm a bit hesitant with the code example translations: Should I translate the method's argument names too?

Copy link
Contributor

@icarlossz icarlossz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I left you some comments.

content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
@d4vsanchez
Copy link
Contributor Author

@icarlossz Thanks! I've just fixed them in a new commit.

@carburo
Copy link
Member

carburo commented Feb 5, 2019

@d4vsanchez Sorry for the late response. Code blocks shouldn't be translated (with the exception of comments inside them).

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @d4vsanchez, this is awesome, thanks for your contribution.

This LGTM - :shipit:

@alejandronanez alejandronanez merged commit 789ee56 into reactjs:master Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants