-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility translation #74
Accessibility translation #74
Conversation
Hey @ElRodrigote, what's the state of this PR? Are you still working on it? Thanks! |
@alejandronanez Hi! Yes, I had a few personal issues this week but I'm working on it, I'll update now what I have so far. Sorry for the delay and not giving you guys an update status. |
all good @ElRodrigote no problem! thanks for letting us know! |
Pending: proof reading.
….reactjs.org into accessibility-translation
Hi @alejandronanez ! Finally I've finished translating and proof reading the file, it was quite extensive haha, sorry for the delay, If you could please take a look and review it, it would be awesome. I have a quick question, regarding titles having some kind of reference between braces. I've deleted them in the file, but would like to know if I should: Cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ElRodrigote, thanks for this!
Generally speaking, I see 3 things that we need to change.
- Bring back the
#
next to the titles - Please, avoid the usage of
usted
in any form, we're writing everything withtú
- Remove the extra spaces in line # 9, all the text is bold now :D
Thank you,
… adding deleted IDs.
Hi @alejandronanez ! Thanks for the corrections and the review. I've noticed a few orthographic errors too so I fixed them. Please, let me know if any further changes are needed. Cheers! |
Deploy preview for es-reactjs ready! Built with commit feb73b6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @ElRodrigote, thanks for your hard work!
Thank you guys! |
No description provided.