Translate: Fragments #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elyalvarado
suggested changes
Feb 5, 2019
|
Thanks @elyalvarado. I did the proper fixes you suggested. |
alejandronanez
requested changes
Feb 6, 2019
There was a problem hiding this comment.
Hey @RamirezAlex, thanks for wrapping this up!
The only big change I think we should do here, is to change the code back to English.
Besides that, everything looks 👍
content/docs/fragments.md
Outdated
|
|
||
| ```jsx | ||
| class Columns extends React.Component { | ||
| render() { | ||
| return ( | ||
| <div> | ||
| <td>Hello</td> | ||
| <td>World</td> | ||
| <td>Hola</td> |
There was a problem hiding this comment.
Hey @RamirezAlex, we're leaving the code as is, we're only translating comments. So please, leave this as <td>Hello</td>
We use lots of codepen examples, and if we translate the code contents we could confuse people!
content/docs/fragments.md
Outdated
|
|
||
| ```jsx | ||
| function Glossary(props) { | ||
| return ( | ||
| <dl> | ||
| {props.items.map(item => ( | ||
| // Without the `key`, React will fire a key warning | ||
| // Sin la 'key', React disparará una advertencia de key |
There was a problem hiding this comment.
Maybe this could sound better as
Suggested change
| // Sin la 'key', React disparará una advertencia de key | |
| // Sin el prop 'key', React disparará una advertencia de key |
alejandronanez
requested changes
Feb 6, 2019
|
Thank you @alejandronanez I updated the PR. |
alejandronanez
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #80
Please review.