-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate Tutorial #83
Conversation
Hey @ivandevp, this is a tough one! I'd say |
Hey @alejandronanez, thanks for your answer. Yeah, I think that could be the right translation. Basically, I thought it's a keyword so used in dev and job environment, that's why I suggested to keep it in English, but if you think it's better understandable in Spanish, I'll go for it. Thanks again! |
content/tutorial/nav.yml
Outdated
- id: what-are-we-building | ||
title: What Are We Building? | ||
href: /tutorial/tutorial.html#what-are-we-building | ||
- id: que-estamos-construyendo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave the ids untranslated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, got it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Hey @tesseralis @alejandronanez ! When pulling changes from upstream, navigation ids were added to the markdown in all headings. I'm not sure how that works, but those are seen in the rendered page: Are they going to be hidden in build step or it's a bug and we need to fix it? |
@ivan yup, that's how they work. They're not supported in the github viewer but we added a plugin so they're supported in the site! |
Great! Thanks for your reply @tesseralis. |
Hey guys! I finished translating the tutorial (it was really long 😅). I took some assumptions that I want to confirm with you if are ok, I know about the |
Hey @ivandevp, thanks for all the hard work! I’ll take a look at this tomorrow night! Thanks again!!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ivandevp, thanks for your PR - this is a huge document, thanks for taking the time to work on it!
I requested a few changes here before merging, please, let me (us) know if you need any help or if something is not clear enough!
Thanks again!
Great review @alejandronanez ! Thanks for all the comments left, I've just updated the fixes, let me know if we should improve anything else, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey again @ivandevp,
Thanks for addressing all the comments so quickly - what an awesome job you've done here, this was a huuuge PR, thanks for all the hard work.
This is looking good to merge!
Welcome to the project! 🎉
Awesome! Great news to see @alejandronanez ! I would like to contribute more, I have a little bit of free time, even if I can help maintaining the repo is an option if needed. Let me know how else may I help when you can. |
I have a doubt for how to translate time travel, I think it should remain in English, any suggestions?