Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate: Environment Requirements #87

Merged
merged 5 commits into from
Feb 11, 2019

Conversation

angelitaooo
Copy link
Contributor

Relates to #4

@alejandronanez alejandronanez changed the title translate Translate: Environment Requirements Feb 6, 2019
Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @angelitaooo,

Congratulations for sending your first PR - this is looking good so far, I left a couple of minor changes that you should address in order to approve this PR.

Let us know when it's ready!

Thanks!

@tesseralis
Copy link
Member

@alejandronanez the changes were easy enough I went ahead and did them myself. 🙂Will you take a look?

@carburo
Copy link
Member

carburo commented Feb 10, 2019

@alejandronanez Seems fine for me, it is a small page. I just fixed a typo (collección -> colección) and the inconsistent use of 'environment' (once as 'ambiente', once as 'entorno'). There is another small issue with the use of 'soportar' for tranlationg 'support', but I think we can leave that to the style guide. For me, it's ready to be merged.

@alejandronanez
Copy link
Member

Say no more @carburo!

Merging!

@alejandronanez alejandronanez merged commit 398aa5e into reactjs:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants