ci: lint automation using github workflow textlint_lint.yml and lint-staged (#926 #971)
#1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumirlumir
requested review from
hg-pyun,
taehwanno,
simsim0709,
gnujoow,
b9words,
taggon,
MaxKim-J and
eomttt
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요😊 textlint를 이용한 lint 검증 자동화를 완료하였습니다.
아직 모든 translate glossary가 포함된건 아니지만, 지금까지 70% 정도 진행된 내용을 바탕으로 검증되도록 하였습니다.
변경 내용은 아래와 같습니다.
textlint_lint.ymlsrc하위 디렉토리의 마크다운 파일들이 변경되었을 때, textlint 관련 파일들이 변경되었을 때, 현재 워크플로 파일이 변경되었을 때 검사를 진행합니다.package.jsonyarn textlint-lint스크립트를 추가하여, pre-commit 훅에서 자동 검증이 진행되도록 하였습니다.Note
현재 PR에서 workflow가 정상 동작합니다.
resolve: #926, #971
@hg-pyun
Progress