Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test automation using github workflow textlint_test.yml #1051

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

lumirlumir
Copy link
Collaborator

@lumirlumir lumirlumir commented Sep 20, 2024

안녕하세요😊 textlint의 자체 test 검증 자동화를 완료하였습니다.

이전 #1048 PR과 유사한 방식으로 진행하였습니다.

다만, lint-staged에는 test 관련 내용이 이미 포함되어 있기 때문에 이 부분은 따로 추가하지 않았습니다.

변경 내용은 아래와 같습니다.

  1. textlint_test.yml
    • 파일 이름 및 변수 이름들은 기존 workflows 들과 동일한 컨벤션을 사용하여 명명하였습니다.
    • textlint 관련 파일들이 변경되었을 때와 현재 워크플로 파일이 변경되었을 때 검사를 진행합니다.

Note

현재 PR에서 workflow가 정상 동작합니다.

image

@hg-pyun

Progress

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ko-legacy-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2024 6:14am

Copy link

github-actions bot commented Sep 20, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@lumirlumir lumirlumir marked this pull request as ready for review September 20, 2024 14:29
@lumirlumir lumirlumir enabled auto-merge (squash) September 20, 2024 14:31
@lumirlumir lumirlumir changed the title ci: test automation using github workflow textlint_test.yml ci: test automation using github workflow textlint_test.yml Sep 20, 2024
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다

@lumirlumir lumirlumir merged commit 38aba87 into reactjs:main Sep 22, 2024
5 of 6 checks passed
@lumirlumir lumirlumir deleted the ci-textlint-test-automation branch September 22, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants