-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fixed] Call parent.removeChild only if parent exists #778
Conversation
Hi @husseyexplores, Thanks for the PR. As mentioned in the issue, you can add a warning telling that the element has gone. |
Thanks for the follow-up! |
Yep. 👍 |
Added the warning message. Let me know if it needs to be rephrased. |
Here is an example of a message we are already using https://github.com/reactjs/react-modal/blob/master/src/components/ModalPortal.js#L93. This should be the last thing. |
Thanks, @husseyexplores. I'll review it. |
Fixes #769
Should we also check before calling removeChild here (In
componentDidUpdate()
?I'm fairly new to contributing to open-sourced projects. Please let me know if I made any mistakes. Thank you!
Acceptance Checklist:
CONTRIBUTING.md
.