Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixed] Call parent.removeChild only if parent exists #778

Merged
merged 3 commits into from
Nov 15, 2019
Merged

[fixed] Call parent.removeChild only if parent exists #778

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
641df86
[fixed] Call parent.removeChild only if parent exists
husseyexplores Oct 11, 2019
4490386
Warn if the modal parent is already removed
husseyexplores Oct 11, 2019
35aa2ad
Rephrased warning message
husseyexplores Oct 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/components/Modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,16 @@ class Modal extends Component {
removePortal = () => {
!isReact16 && ReactDOM.unmountComponentAtNode(this.node);
const parent = getParentElement(this.props.parentSelector);
parent.removeChild(this.node);
if (parent) {
parent.removeChild(this.node);
} else {
// eslint-disable-next-line no-console
console.warn(
'React-Modal: "parentSelector" prop did not returned any DOM ' +
"element. Make sure that the parent element is unmounted to " +
"avoid any memory leaks."
);
}
};

portalRef = ref => {
Expand Down