Add back basename support in match() #3054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taion
added a commit
that referenced
this pull request
Feb 10, 2016
Add back basename support in match()
|
I tried to get this working in my example repo https://github.com/wordofchristian/react-router-error-demo, it seems to be broken for a different reason. The |
|
I'm facing the same problem and would be very interested in getting an example on how to use basename with server side rendering. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3003
Looks like we broke this inadvertently back in #2743. Specifically, we did so here: #2743 (comment)
Users should use a custom history from now on, but this maintains BC with 1.0.