Skip to content

Translate "Getting Started" (getting-started.md) #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 11, 2019
Merged

Translate "Getting Started" (getting-started.md) #39

merged 11 commits into from
Feb 11, 2019

Conversation

AlLevykin
Copy link
Contributor

No description provided.

@avevlad avevlad mentioned this pull request Feb 9, 2019
Closed
lex111
lex111 requested changes Feb 9, 2019
View reviewed changes
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо, коммментарии очень беглого обзора, пока рекомендуем прочитать руководство.

@lex111 lex111 added the needs review A pull request ready to be reviewed label Feb 9, 2019
@lex111 lex111 requested a review from gaearon February 9, 2019 23:20
gaearon
gaearon requested changes Feb 10, 2019
View reviewed changes
Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я оставил первые несколько комментариев — проблемные места похожи, так что я предлагаю их поправить и пройтись по всему тексту в поисках похожих проблем. Потом посмотрю еще )

Спасибо.

@tesseralis tesseralis mentioned this pull request Feb 10, 2019
Closed
88 tasks
gaearon
gaearon reviewed Feb 10, 2019
View reviewed changes
Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Уже лучше! Несколько замечаний.

@gaearon gaearon added work in progress Author opened the pull-request but it's still being worked on and removed needs review A pull request ready to be reviewed labels Feb 10, 2019
gaearon
gaearon requested changes Feb 10, 2019
View reviewed changes
Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Еще один раунд, мы близко

gaearon
gaearon reviewed Feb 11, 2019
View reviewed changes
gaearon
gaearon approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

С моей стороны всё ок, оставляю @lex111 на мёрж

@lex111 lex111 merged commit 0672717 into reactjs:master Feb 11, 2019
@lex111
Copy link
Member

lex111 commented Feb 11, 2019

@AlLevykin спасибо!

@lex111 lex111 mentioned this pull request Feb 11, 2019
Merged
@gaearon gaearon mentioned this pull request Feb 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avevlad avevlad avevlad left review comments

@gaearon gaearon gaearon approved these changes

@lex111 lex111 lex111 approved these changes

Assignees
No one assigned
Labels
work in progress Author opened the pull-request but it's still being worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlLevykin @lex111 @gaearon @avevlad