Skip to content

Rules of Hooks translation #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 28, 2019
Merged

Rules of Hooks translation #86

merged 7 commits into from
Feb 28, 2019

Conversation

airyboy
Copy link

@airyboy airyboy commented Feb 11, 2019

No description provided.

@airyboy airyboy mentioned this pull request Feb 11, 2019
Closed
88 tasks
@another-guy another-guy added the needs review A pull request ready to be reviewed label Feb 11, 2019
@another-guy another-guy mentioned this pull request Feb 12, 2019
Closed
lex111
lex111 reviewed Feb 12, 2019
View reviewed changes
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хороший старт, небольшое ревью

@another-guy another-guy added work in progress Author opened the pull-request but it's still being worked on and removed needs review A pull request ready to be reviewed labels Feb 12, 2019
Mikhail Menshikov added 3 commits February 15, 2019 08:54
@another-guy another-guy self-assigned this Feb 16, 2019
another-guy
another-guy reviewed Feb 20, 2019
View reviewed changes
@another-guy
Copy link
Collaborator

another-guy commented Feb 20, 2019 •
edited
Loading

@airyboy good job! Немного замечаний по стилю и консистентности с другими переводами. До аппрува -- рукой подать. Спасибо!

@another-guy another-guy removed their assignment Feb 20, 2019
lex111
lex111 approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зафиксировал предложенные изменения от @another-guy и @ntishkevich + добавил кое-что своё.

@lex111 lex111 merged commit ea20319 into reactjs:master Feb 28, 2019
@lex111
Copy link
Member

lex111 commented Feb 28, 2019

Спасибо @airyboy за перевод, а также @pavelkeyzik, @lfedorov, @another-guy и @ntishkevich за ревью! 🎉

Все прочие улучшения/доработки в отдельных PR.

@lex111 lex111 added needs proofread A read-through is still needed to release the document and removed work in progress Author opened the pull-request but it's still being worked on labels Feb 28, 2019
@netlify
Copy link

netlify bot commented Feb 28, 2019

Deploy preview for ru-reactjs ready!

Built with commit 085e5c6

https://deploy-preview-86--ru-reactjs.netlify.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon left review comments

@angryermine angryermine angryermine left review comments

@another-guy another-guy another-guy left review comments

@ntishkevich ntishkevich ntishkevich left review comments

@pavelkeyzik pavelkeyzik pavelkeyzik left review comments

@lex111 lex111 lex111 approved these changes

Assignees
No one assigned
Labels
needs proofread A read-through is still needed to release the document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@airyboy @another-guy @lex111 @gaearon @angryermine @ntishkevich @pavelkeyzik