SwitchOnFirst better tracks in/out premature close #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegDokuka
changed the title
OlegDokuka
force-pushed
the
bugfix/sof-premature-close-fix
branch
3 times, most recently
from
14c5f49
to
091c52c
Compare
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
OlegDokuka
force-pushed
the
bugfix/sof-premature-close-fix
branch
from
091c52c
to
ed829be
Compare
added 3 commits
September 28, 2021 12:41
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
simonbasle
approved these changes
Sep 28, 2021
simonbasle
changed the title
chemicL
added a commit
that referenced
this pull request
Nov 21, 2024
In a situation where `SwitchOnFirstMain` is subscribed to after the operator itself has terminated, the expectation is that either an error is propagated due to cancellation of the source or the first actual subscription succeeds. Due to a regression introduced in #2794 the subscription would hang with no termination. This change addresses the issue and the subscrption properly terminates. Related to #3936. Signed-off-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com>
chemicL
added a commit
that referenced
this pull request
Nov 21, 2024
In a situation where `SwitchOnFirstMain` is subscribed to after the operator itself has terminated, the expectation is that either an error is propagated due to cancellation of the source or the first actual subscription succeeds. Due to a regression introduced in #2794 the subscription would hang with no termination. This change addresses the issue and the subscrption properly terminates. Related to #3936. Signed-off-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an extra state to indicate the scenario when the downstream cancels / receives an error before the inner upstream was terminated. In that case, we generate inbound prematurely close to propagate extra cancellation exception
Signed-off-by: Oleh Dokuka odokuka@vmware.com