Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support promise cancellation for coroutine() and clean up garbage references #13

Merged
merged 3 commits into from
Nov 19, 2021

Conversation

clue
Copy link
Member

@clue clue commented Nov 19, 2021

This changeset adds support for promise cancellation for the new coroutine() function. You can now call cancel() on the resulting promise to cancel all pending promises within the coroutine. On top this, we now make sure to clean up any garbage references to not leak any memory.

Builds on top of #9 and #12
Refs reactphp/socket#170 and others

@clue clue added the new feature New feature or request label Nov 19, 2021
@clue clue added this to the v3.0.0 milestone Nov 19, 2021
@clue clue requested a review from WyriHaximus November 19, 2021 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants