Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DNS error messages and cancellation forwarding after DNS lookup #170

Merged
merged 3 commits into from
Aug 2, 2018

Conversation

clue
Copy link
Member

@clue clue commented Aug 1, 2018

This PR improves DNS error messages (if connector fails due to DNS lookup) and improves (fixes) cancellation forwarding after the DNS lookup. This ensures that cancelling a pending connection attempt will properly cancel the underlying TCP/IP connection attempt.

The cancellation forwarding will eventually also be addressed upstream via reactphp/promise#99, but it's currently not decided when this version will be tagged. In the meantime, this PR works around this issue and improves cancellation semantics somewhat.

Refs #168 and #169

@clue clue added this to the v1.1.0 milestone Aug 1, 2018
@clue clue requested review from jsor and WyriHaximus August 1, 2018 16:19
@jsor jsor merged commit cf7c46f into reactphp:master Aug 2, 2018
@clue clue deleted the dns-errors branch August 2, 2018 07:39
clue added a commit to clue-labs/reactphp-redis that referenced this pull request Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants