Include timeout logic to avoid dependency on reactphp/promise-timer #213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds timeout logic to avoid the otherwise unneeded dependency on reactphp/promise-timer. There are plans to deprecate the reactphp/promise-stream package as discussed in https://github.com/orgs/reactphp/discussions/475 and in either case I'd like to remove additional dependencies where possible.
In particular, reactphp/dns and reactphp/socket appear to be the only ReactPHP packages that depend on reactphp/promise-timer at the moment. Most consumers of this package will likely install it as a dependency of reactphp/socket, so most consumers will likely continue installing this dependency until it is also removed from reactphp/socket. I have already prepared a similar follow-up PR for reactphp/socket to remove this dependency to ensure most consumers will no longer install reactphp/promise-timer by default.
This changeset does not otherwise affect our public API, so this should be safe to apply. The test suite confirms this has 100% code coverage and does not otherwise affect our APIs.
Note that this changeset does not preclude the discussion in https://github.com/orgs/reactphp/discussions/475, so whether or not or when the package will be deprecated is still up for debate. If you want to explicitly install this dependency, you can still install it like this:
Builds on top of #204, #206 and others
See also reactphp/http#482 for similar changes to remove reactphp/promise-stream from reactphp/http