Include buffer logic to avoid dependency on reactphp/promise-stream #482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds buffering logic to avoid the otherwise unneeded dependency on reactphp/promise-stream. There are plans to deprecate that package as discussed in https://github.com/orgs/reactphp/discussions/475 and in either case I'd like to remove additional dependencies where possible.
In particular, reactphp/http appears to be the only ReactPHP package that depends on reactphp/promise-stream at the moment. This means that most consumers of this package would no longer install reactphp/promise-stream at all. Perhaps most notably, this means that IDE autocompletion for
all()
would now only suggest the correctReact\Promise\all()
function instead of the rarely usefulReact\Promise\Stream\all()
function.This changeset does not otherwise affect our public API, so this should be safe to apply. The test suite confirms this has 100% code coverage and does not otherwise affect our APIs. This improves error reporting slightly, but I've tried to keep changes to a minimum otherwise.
Note that this changeset does not preclude the discussion in https://github.com/orgs/reactphp/discussions/475, so whether or not or when the package will be deprecated is still up for debate. If you want to explicitly install this dependency, you can still install it like this:
Builds on top of #480, #460 and others
Refs #468