Add PSR-7 ServerRequestInterface to the PSR-7 Request #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
approved these changes
Apr 20, 2017
There was a problem hiding this comment.
Thanks for taking the time to break this down from #160, this makes it waaay easier to review 👍
LGTM 
For the reference: We may want to eventually move the ServerRequest implementation upstream, is this something you've already looked in to? Given that this class is currently marked internal, I don't see this as a blocker and want to get this in despite 👍
jsor
approved these changes
Apr 20, 2017
WyriHaximus
approved these changes
Apr 20, 2017
|
Just noticed that the |
Merged
This was referenced Mar 13, 2024
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a PSR-ServerRequestInterface to the request.
This won't handle server params, cookies or uploaded files. This will be addressed in several other PRs.
The new class makes it possible to handle parsed request bodies (#105 for v0.8.0).