Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PSR-7 ServerRequestInterface to the PSR-7 Request #170

Merged
merged 2 commits into from
Apr 20, 2017

Conversation

legionth
Copy link
Contributor

This PR adds a PSR-ServerRequestInterface to the request.
This won't handle server params, cookies or uploaded files. This will be addressed in several other PRs.
The new class makes it possible to handle parsed request bodies (#105 for v0.8.0).

Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to break this down from #160, this makes it waaay easier to review 👍

LGTM :shipit:

For the reference: We may want to eventually move the ServerRequest implementation upstream, is this something you've already looked in to? Given that this class is currently marked internal, I don't see this as a blocker and want to get this in despite 👍

@clue clue added this to the v0.7.0 milestone Apr 20, 2017
@WyriHaximus WyriHaximus self-requested a review April 20, 2017 18:12
@clue clue merged commit 90e3700 into reactphp:master Apr 20, 2017
@andig
Copy link
Contributor

andig commented Apr 26, 2017

Just noticed that the Server inline examples are all still using RequestInterface instead of ServerRequestInterface

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants