Add new Uri class for new PSR-7 implementation
#521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
force-pushed
the
psr7-uri
branch
2 times, most recently
from
4e815b6
to
5c5b426
Compare
SimonFrings
approved these changes
Mar 26, 2024
WyriHaximus
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds a new
Uriclass that builds on top of our new PSR-7 implementation. This brings us one step closer to eventually replace the dated RingCentral implementation (#331) and eventually support PSR-7 v2 (#513). This is a mostly an internal change, but also exposes the newUriclass as part of our public API. Perhaps most notably, this means theRequestandServerRequestclasses will now return instances of ourUriclass (#519) instead of using the legacy RingCentral classes. It comes with 100% code coverage and does not otherwise affect the public API, so it should be safe to apply.This builds on top of the recent changes for the
ResponseandServerRequestclasses (#518 and #519), but this similar to #520 doesn't show a noticeable impact on performance during my benchmarks. As a consequence, I consider this mostly a simple feature addition only.Once merged, I'll file follow-up PRs to remove any leftover references to the old RingCentral implementation accordingly. If you enjoy this change and want to help us continue to ship more improvements, consider supporting this project, for example by becoming a sponsor ❤️
Builds on top of #520, #519, #518, #480, #432, #370, #170 and others