Fix calculating concurrency when post_max_size ini is unlimited
#365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
approved these changes
Jul 4, 2020
jsor
approved these changes
Jul 4, 2020
This was referenced Jul 6, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
post_max_sizeto0means the HTTP request body size is unlimited. This has a similar effect to setting it to a very large value (e.g.4G). Accordingly, we have to limit concurrency to not exceed thememory_limitsetting (see also #342).In other words, this is more of an edge case and it's usually not recommended to allow keeping a very large HTTP request body in memory. The
post_max_sizeshould be limited to a reasonable value to support decent concurrency.Resolves #360