Improve default concurrency and cap default request buffer at 64K #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
approved these changes
Jul 10, 2020
jsor
approved these changes
Jul 11, 2020
This was referenced Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset improves default concurrency to 1024 and caps the default request buffer at 64K. The previous defaults resulted in just 4 concurrent requests with a request buffer of 8M.
If a request exceeds this limit, its request body will be ignored and it will be processed like a request with no request body at all. As such, I consider this to be a BC break that will affect consumers of this project processing large request bodies (think file uploads and large form etc.). I've updated the documentation to include details on how to override these defaults.
Builds on top of #367, #361 and #362
Refs #365 and others