Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve default concurrency and cap default request buffer at 64K #371

Merged
merged 1 commit into from
Jul 11, 2020

Conversation

clue
Copy link
Member

@clue clue commented Jul 10, 2020

This changeset improves default concurrency to 1024 and caps the default request buffer at 64K. The previous defaults resulted in just 4 concurrent requests with a request buffer of 8M.

If a request exceeds this limit, its request body will be ignored and it will be processed like a request with no request body at all. As such, I consider this to be a BC break that will affect consumers of this project processing large request bodies (think file uploads and large form etc.). I've updated the documentation to include details on how to override these defaults.

Builds on top of #367, #361 and #362
Refs #365 and others

@clue clue added this to the v1.0.0 milestone Jul 10, 2020
@clue clue requested review from WyriHaximus and jsor July 10, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants